feat: Added in-memory storage for testing purposes by Harshdev098 · Pull Request #59 · lightningdevkit/vss-server

Harshdev098 · 2025-10-12T08:40:04Z

Have added in_memory store for testing purpose.
We can edit config file to use specific store either postgresql or memory

ldk-reviews-bot · 2025-10-12T08:40:06Z

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Harshdev098 · 2025-10-12T10:19:04Z

Hey @tnull @tankyleo Can you please review it

tnull

Thanks for looking into this!

Generally goes into the right direction, but we def. need to avoid re-allocating everything on every operation.

rust/Cargo.lock

rust/README.md

rust/impls/src/lib.rs

rust/impls/src/memory_store.rs

Harshdev098 · 2025-10-14T06:17:50Z

@tnull Have done the required changes

tnull

Looks much better, but I think we still need to handle global_version properly, even if we're currently not using it client-side.

rust/impls/src/in_memory_store.rs

ldk-reviews-bot · 2025-10-14T08:50:52Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2025-10-16T08:51:33Z

🔔 2nd Reminder

Hey @tnull @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2025-10-16T16:44:43Z

🔔 1st Reminder

Hey @tnull @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull

One comment, will take another look once @tankyleo also had a chance to do a review round here.

rust/impls/src/in_memory_store.rs

Harshdev098 · 2025-10-17T09:15:56Z

@tankyleo Can you please review it!

ldk-reviews-bot · 2025-10-18T08:52:14Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2025-10-20T08:52:50Z

🔔 4th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2025-10-22T08:53:27Z

🔔 5th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Sorry for the delay !

rust/impls/src/in_memory_store.rs

tankyleo · 2025-10-22T23:59:11Z

rust/impls/src/in_memory_store.rs

+					version: record.version,
+				}),
+			})
+		} else if request.key == GLOBAL_VERSION_KEY {


Looks like by the time we are here, we know the GLOBAL_VERSION_KEY does not have a value, otherwise guard.get would have returned Some previously. We can just return the GetObjectResponse below directly with version: 0.

@Harshdev098 double checking things here, we still have this second branch the same as before ?

Shouldn't we still return early if request.key == GLOBAL_VERSION_KEY rather than always first making the lookup?

The first lookup handles cases where the GLOBAL_VERSION_KEY is some non-zero value. We want to check whether it's been set to some value in the map before returning the initial value in this branch.

rust/impls/src/in_memory_store.rs

rust/impls/src/migrations.rs

Harshdev098 · 2025-10-26T01:53:09Z

@tankyleo Have done with the required changes! Can you please review it

tnull

When testing integration with LDK Node locally I found that the tests are currently failing. I now opened #62 to add LDK Node integration tests to our CI here. It would be great if that could land first, and we could also add a CI job for the in-memory store as part of this PR then, ensuring the implementation actually works as expected.

ldk-reviews-bot · 2025-10-28T01:53:31Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2025-10-30T01:54:18Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2025-10-31T12:09:51Z

@Harshdev098 Please rebase now that #62 landed to make use of the new CI checks here.

ldk-reviews-bot · 2026-01-14T00:02:19Z

🔔 22nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Thanks for the rebase !

Can you squash the 3rd commit into the 1st commit ? Let's ship the improved version in a single commit.

Also CI is failing can you take a look ? Thank you

tankyleo · 2026-01-14T04:50:24Z

rust/server/Cargo.toml

+[[bin]]
+name = "vss-server"
+path = "src/main.rs"


Help me understand I don't think we need this ?

tankyleo · 2026-01-14T04:53:45Z

Will take a deeper look this week at the code

tankyleo · 2026-01-14T17:02:53Z

Can you squash the 3rd commit into the 1st commit ? Let's ship the improved version in a single commit.

@Harshdev098 can you do this one ? Thank you

Harshdev098 · 2026-01-14T17:51:12Z

@tankyleo Have squashed those commits

tankyleo · 2026-01-17T04:00:54Z

rust/server/Cargo.toml

+[[bin]]
+name = "vss-server"
+path = "src/main.rs"


@Harshdev098 before I take a deeper look can you explain this one ? It doesn't seem necessary.

Actually earlier the CI test are failing for not finding a bin or something like that, but now have reverted does changes!

ldk-reviews-bot · 2026-01-21T18:52:57Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-24T00:00:28Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-26T00:01:41Z

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-28T00:02:20Z

🔔 4th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-01-31T00:00:20Z

🔔 5th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-02-02T00:01:00Z

🔔 6th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-02-04T00:01:29Z

🔔 7th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot requested a review from tankyleo October 12, 2025 08:50

tnull self-requested a review October 13, 2025 07:10

tnull reviewed Oct 13, 2025

View reviewed changes

Harshdev098 force-pushed the memory_store branch 2 times, most recently from 4980a75 to 25d57e3 Compare October 14, 2025 06:16

Harshdev098 requested a review from tnull October 14, 2025 06:17

tnull reviewed Oct 14, 2025

View reviewed changes

rust/impls/src/in_memory_store.rs Show resolved Hide resolved

Harshdev098 force-pushed the memory_store branch from 25d57e3 to 9012e95 Compare October 14, 2025 12:24

Harshdev098 requested a review from tnull October 14, 2025 16:44

tnull reviewed Oct 17, 2025

View reviewed changes

rust/impls/src/in_memory_store.rs Outdated Show resolved Hide resolved

Harshdev098 force-pushed the memory_store branch from 9012e95 to 3b434d0 Compare October 17, 2025 09:14

tankyleo reviewed Oct 23, 2025

View reviewed changes

Harshdev098 force-pushed the memory_store branch from 3b434d0 to e0c31bb Compare October 26, 2025 01:51

Harshdev098 requested a review from tankyleo October 26, 2025 01:53

Harshdev098 force-pushed the memory_store branch from 8003119 to 5898609 Compare October 26, 2025 02:18

tnull reviewed Oct 27, 2025

View reviewed changes

tnull requested review from tnull and removed request for tnull January 12, 2026 14:36

Harshdev098 force-pushed the memory_store branch from 257c45b to 749c0ea Compare January 14, 2026 04:20

tankyleo reviewed Jan 14, 2026

View reviewed changes

Harshdev098 force-pushed the memory_store branch 3 times, most recently from f870179 to ba0d247 Compare January 14, 2026 14:28

Harshdev098 force-pushed the memory_store branch 4 times, most recently from e30765f to 687efd7 Compare January 14, 2026 17:50

tankyleo self-requested a review January 17, 2026 03:11

tankyleo reviewed Jan 17, 2026

View reviewed changes

feat: Added in-memory storage for testing purposes

51adba8

Harshdev098 force-pushed the memory_store branch 2 times, most recently from 6050d90 to 1c937bd Compare January 18, 2026 07:21

feat: Added CI for in_memory_testing

4fc9d0f

Harshdev098 force-pushed the memory_store branch from 1c937bd to 4fc9d0f Compare January 18, 2026 07:55

tankyleo self-requested a review January 19, 2026 18:52

Conversation

Harshdev098 commented Oct 12, 2025

Uh oh!

ldk-reviews-bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Harshdev098 commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harshdev098 commented Oct 14, 2025

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ldk-reviews-bot commented Oct 14, 2025

Uh oh!

ldk-reviews-bot commented Oct 16, 2025

Uh oh!

ldk-reviews-bot commented Oct 16, 2025

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Harshdev098 commented Oct 17, 2025

Uh oh!

ldk-reviews-bot commented Oct 18, 2025

Uh oh!

ldk-reviews-bot commented Oct 20, 2025

Uh oh!

ldk-reviews-bot commented Oct 22, 2025

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tankyleo Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

tankyleo Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

tnull Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

tankyleo Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harshdev098 commented Oct 26, 2025

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

ldk-reviews-bot commented Oct 28, 2025

Uh oh!

ldk-reviews-bot commented Oct 30, 2025

Uh oh!

tnull commented Oct 31, 2025

Uh oh!

ldk-reviews-bot commented Oct 12, 2025 •

edited

Loading

Harshdev098 commented Oct 12, 2025 •

edited

Loading